Today I have a Holden Astra with a suspension knock noise. The front suspension strut tops have collapsed which is causing the noise.
I removed and replaced these with new units, quiet and easy job with the correct tools. Not a job to ever try without a quality spring compressor as there is a lot of stored energy in the springs.
Once the strut tops are replaced the vehicle requires a wheel alignment. Then its back to quiet ‘knock’ free driving.